Extend Network resource to use custom templates#121
Open
jgomezve wants to merge 1 commit intoCiscoDevNet:masterfrom
Open
Extend Network resource to use custom templates#121jgomezve wants to merge 1 commit intoCiscoDevNet:masterfrom
jgomezve wants to merge 1 commit intoCiscoDevNet:masterfrom
Conversation
jgomezve
commented
Feb 2, 2023
| if err != nil { | ||
| return err | ||
| if networkConfig, ok := d.GetOk("template_props"); ok { | ||
| networkConfigMap := networkConfig.(map[string]interface{}) |
Author
There was a problem hiding this comment.
Not sure if we should assign the values in the key template_props directly without any further verification. I would argue that users setting the key template_props must be completely sure that the JSON payload is built based on those values without further verification
Maybe we should only check if the VLAN ID and the Multicast group are part of the keys. If not we generate them. What are your thoughts?
There was a problem hiding this comment.
I think having a check to ensure the template_props are verified is a good step to add. Yes, i think VLAN ID and multicast group are a good start. I'll think more about what other parameters are important.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #111